Change in vdsm[master]: vm: downgrade logs about expected flows

fromani at redhat.com fromani at redhat.com
Wed Oct 22 11:53:13 UTC 2014


Francesco Romani has uploaded a new change for review.

Change subject: vm: downgrade logs about expected flows
......................................................................

vm: downgrade logs about expected flows

virt flows have plenty of steps, some of them aren't
so significant, so don't bother the user.
This applies both to 'info' -> 'debug', for logs
regarding minor stepsm and to 'warn' -> 'info',
because there are some steps that are totally
expected and handled (e.g. the updaring of
drives with information from libvirt).

Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
M vdsm/virt/vmchannels.py
2 files changed, 10 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/34357/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index cf00792..3c9d138 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2808,7 +2808,7 @@
             self.log.warning('failed to set Vm niceness', exc_info=True)
 
     def _run(self):
-        self.log.info("VM wrapper has started")
+        self.log.debug("VM wrapper has started")
         self.conf['smp'] = self.conf.get('smp', '1')
         devices = self.buildConfDevices()
 
@@ -4946,8 +4946,8 @@
                 # migration the paths were not in sync anymore (BZ#1059482).
                 if (hasattr(d, 'alias') and d.alias == alias
                         and d.path != devPath):
-                    self.log.warning('updating drive %s path from %s to %s',
-                                     d.alias, d.path, devPath)
+                    self.log.info('updating drive %s path from %s to %s',
+                                  d.alias, d.path, devPath)
                     d.path = devPath
                 if d.path == devPath:
                     d.name = name
@@ -4966,9 +4966,9 @@
                 # the vm configuration as well.
                 if ('alias' in dev and dev['alias'] == alias
                         and dev['path'] != devPath):
-                    self.log.warning('updating drive %s config path from %s '
-                                     'to %s', dev['alias'], dev['path'],
-                                     devPath)
+                    self.log.info('updating drive %s config path from %s '
+                                  'to %s', dev['alias'], dev['path'],
+                                  devPath)
                     dev['path'] = devPath
                 if dev['type'] == DISK_DEVICES and dev['path'] == devPath:
                     dev['name'] = name
diff --git a/vdsm/virt/vmchannels.py b/vdsm/virt/vmchannels.py
index eab1c6e..f422f16 100644
--- a/vdsm/virt/vmchannels.py
+++ b/vdsm/virt/vmchannels.py
@@ -51,7 +51,7 @@
         """ Handle an epoll event occurred on a specific file descriptor. """
         reconnect = False
         if (event & (select.EPOLLHUP | select.EPOLLERR)):
-            self.log.info("Received %.08X on fileno %d", event, fileno)
+            self.log.debug("Received %.08X on fileno %d", event, fileno)
             if fileno in self._channels:
                 reconnect = True
             else:
@@ -175,7 +175,7 @@
 
     def run(self):
         """ The listener thread's function. """
-        self.log.info("Starting VM channels listener thread.")
+        self.log.debug("Starting VM channels listener thread.")
         self._quit = False
         try:
             while not self._quit:
@@ -183,12 +183,12 @@
         except:
             self.log.exception("Unhandled exception caught in vm channels "
                                "listener thread")
-        self.log.info("VM channels listener thread has ended.")
+        self.log.debug("VM channels listener thread has ended.")
 
     def stop(self):
         """" Stop the listener execution. """
         self._quit = True
-        self.log.info("VM channels listener was stopped.")
+        self.log.debug("VM channels listener was stopped.")
 
     def settimeout(self, seconds):
         """ Set the timeout value (in seconds) for all channels. """


-- 
To view, visit http://gerrit.ovirt.org/34357
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib041d4c844fe948523942d76236d291ecf3eb0fb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list