Change in vdsm[master]: vm: promote some debug messages to warn

fromani at redhat.com fromani at redhat.com
Wed Oct 22 11:53:13 UTC 2014


Francesco Romani has uploaded a new change for review.

Change subject: vm: promote some debug messages to warn
......................................................................

vm: promote some debug messages to warn

Promote to 'warn' some logs which reveal
behaviour that may surprise the user.

This patch is part of the preparation for
the switch to default log level to 'info'
in VDSM.

Change-Id: Id7757e7215631f06e93014552363c2ed069ffa47
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 6 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/34356/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 73ff42d..cf00792 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2211,7 +2211,7 @@
         try:
             self.cont()
         except libvirt.libvirtError:
-            self.log.debug("VM %s can't be resumed", self.id, exc_info=True)
+            self.log.warn("VM %s can't be resumed", self.id, exc_info=True)
         self._setWriteWatermarks()
 
     def _acquireCpuLockWithTimeout(self):
@@ -3096,17 +3096,17 @@
                 self._dom.updateDeviceFlags(vnicStrXML,
                                             libvirt.VIR_DOMAIN_AFFECT_LIVE)
                 dev._deviceXML = vnicStrXML
-                self.log.debug("Nic has been updated:\n %s" % vnicStrXML)
+                self.log.info("Nic has been updated:\n %s" % vnicStrXML)
                 hooks.after_update_device(vnicStrXML, self.conf, custom)
             except Exception as e:
-                self.log.debug('Request failed: %s', vnicStrXML, exc_info=True)
+                self.log.warn('Request failed: %s', vnicStrXML, exc_info=True)
                 hooks.after_update_device_fail(vnicStrXML, self.conf, custom)
                 raise SetLinkAndNetworkError(e.message)
             yield
         except Exception:
             # Rollback link and network.
-            self.log.debug('Rolling back link and net for: %s', dev.alias,
-                           exc_info=True)
+            self.log.warn('Rolling back link and net for: %s', dev.alias,
+                          exc_info=True)
             self._dom.updateDeviceFlags(vnicXML.toxml(encoding='utf-8'),
                                         libvirt.VIR_DOMAIN_AFFECT_LIVE)
             raise
@@ -4989,7 +4989,7 @@
                            'readonly': str(readonly)}
                 if bootOrder:
                     diskDev['bootOrder'] = bootOrder
-                self.log.debug('Found unknown drive: %s', diskDev)
+                self.log.warn('Found unknown drive: %s', diskDev)
                 self.conf['devices'].append(diskDev)
 
     def _getUnderlyingGraphicsDeviceInfo(self):


-- 
To view, visit http://gerrit.ovirt.org/34356
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id7757e7215631f06e93014552363c2ed069ffa47
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list