Change in vdsm[master]: sp: setDomainRegularRole is implemented by backend

nsoffer at redhat.com nsoffer at redhat.com
Thu Mar 27 22:35:50 UTC 2014


Nir Soffer has posted comments on this change.

Change subject: sp: setDomainRegularRole is implemented by backend
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.ovirt.org/#/c/24495/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 810:         except Exception:
Line 811:             self.log.exception('migration to new master failed')
Line 812:             try:
Line 813:                 self._backend.setDomainRegularRole(newmsd)
Line 814:             except Exception:
> The issue here is with catch all sentence causing a programming mistake bei
This is a trivial fix for an error introduced by moving setDomainRegularRole() to the backend. Your suggestions are welcome but out of scope of this patch. Feel free to send another patch modifying these issues.
Line 815:                 self.log.exception('unable to mark domain %s as regular',
Line 816:                                    newmsd.sdUUID)
Line 817: 
Line 818:             # Do not release the cluster lock if unmount fails. The lock


Line 811:             self.log.exception('migration to new master failed')
Line 812:             try:
Line 813:                 self._backend.setDomainRegularRole(newmsd)
Line 814:             except Exception:
Line 815:                 self.log.exception('unable to mark domain %s as regular',
> Yet another reminder that the "role" field in the metadata is untrustworthy
I think we should fix this trivial typo now, and think later how we want to handle the role field.
Line 816:                                    newmsd.sdUUID)
Line 817: 
Line 818:             # Do not release the cluster lock if unmount fails. The lock
Line 819:             # will prevent other hosts from mounting the master filesystem


-- 
To view, visit http://gerrit.ovirt.org/24495
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49e45ccab0b933a8f1abc988ea0bd60e7b99b7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list