Change in vdsm[master]: network: Introduce the network package

fromani at redhat.com fromani at redhat.com
Fri Mar 28 07:59:16 UTC 2014


Francesco Romani has posted comments on this change.

Change subject: network: Introduce the network package
......................................................................


Patch Set 2:

First things first: I really like this idea.

But I strongly agree with Nir here: for the sake of ease of review, I think you should start with minimal changes like moving files and fixing imports without reorder them (which is of course good but to be done in a later patch).

I'm ok with renaming files for good, since you are renaming them and git can track this.

-- 
To view, visit http://gerrit.ovirt.org/25908
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I532c179d4002ed1e8e5445d02297c8d5a6248647
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No


More information about the vdsm-patches mailing list