Change in vdsm[master]: sp: setDomainRegularRole is implemented by backend

ewarszaw at redhat.com ewarszaw at redhat.com
Thu Mar 27 21:59:02 UTC 2014


Eduardo has posted comments on this change.

Change subject: sp: setDomainRegularRole is implemented by backend
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

Modern engines never try to call deactivateSD in order to migrate MSD.

Please check if this functionality is supported for current versions. If not, masterMigrate() can be safely removed solving the actual issue and more.

http://gerrit.ovirt.org/#/c/24495/1/vdsm/storage/sp.py
File vdsm/storage/sp.py:

Line 810:         except Exception:
Line 811:             self.log.exception('migration to new master failed')
Line 812:             try:
Line 813:                 self._backend.setDomainRegularRole(newmsd)
Line 814:             except Exception:
The issue here is with catch all sentence causing a programming mistake being reported as "migration to new master failed".
Please remove this try except clause.

Narrow the big try except since we really don't expect that log.debug raises and replace it with try finally or a with block wich will release (only) the cluster lock.

There is no point to holding the newmsd master fs mounted after the finalization of the tarCopy() call.

This way master fs and pool MD codes can be splited and more sensible code can be produced.
Line 815:                 self.log.exception('unable to mark domain %s as regular',
Line 816:                                    newmsd.sdUUID)
Line 817: 
Line 818:             # Do not release the cluster lock if unmount fails. The lock


-- 
To view, visit http://gerrit.ovirt.org/24495
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia49e45ccab0b933a8f1abc988ea0bd60e7b99b7d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list