Change in vdsm[master]: Extract bonding options building into a separate function.
wudxw at linux.vnet.ibm.com
wudxw at linux.vnet.ibm.com
Thu Jan 17 02:54:08 UTC 2013
Mark Wu has posted comments on this change.
Change subject: Extract bonding options building into a separate function.
......................................................................
Patch Set 6: (2 inline comments)
....................................................
File vdsm/configNetwork.py
Line 1314: def _buildBondOptions(bondName, bondings):
Line 1315: logger = logging.getLogger("_buildBondOptions")
Line 1316:
Line 1317: # We need to use the newest host info
Line 1318: _ni = netinfo.NetInfo()
Ok, I will rebase this patch to your 'Reduce the amount of netinfo instantiation.' patch.
Line 1319:
Line 1320: bond = {}
Line 1321: if bondings.get(bondName):
Line 1322: bond['nics'] = bondings[bondName]['nics']
Line 1428: # If the new added network was created on top of
Line 1429: # existing bond, we need to keep the bond on rollback
Line 1430: # flow, else we will break the new created bond.
Line 1431: delNetwork(network, force=True,
Line 1432: implicitBonding=networks[network].
Toni, thanks a lot for your explanation!
Line 1433: get('bonding') in bondings)
Line 1434: raise ConfigNetworkError(ne.ERR_LOST_CONNECTION,
Line 1435: 'connectivity check failed')
Line 1436: except:
--
To view, visit http://gerrit.ovirt.org/8885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
More information about the vdsm-patches
mailing list