Change in vdsm[master]: Extract bonding options building into a separate function.

asegurap at redhat.com asegurap at redhat.com
Thu Jan 17 01:23:57 UTC 2013


Antoni Segura Puimedon has posted comments on this change.

Change subject: Extract bonding options building into a separate function.
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1428:                         # If the new added network was created on top of
Line 1429:                         # existing bond, we need to keep the bond on rollback
Line 1430:                         # flow, else we will break the new created bond.
Line 1431:                         delNetwork(network, force=True,
Line 1432:                                    implicitBonding=networks[network].
Ok. Let's see if we get it cleared up so we see if the implicitBonding semantics change.

The old code was just checking that for each network of networksAdded:
  - is in netsWithNewBonds. That means:
     + network is member of networksAdded
     + network has a bonding attribute present in bondings.

  netsWithNewBonds being defined as a list of networks that are being added and have bonding defined in bondings.

The new code checks that each network of networksAdded:
  - has a bonding attribute present in bondings.

So in the end, I think they are the same (if I did not miss anything).
Line 1433:                                    get('bonding') in bondings)
Line 1434:                     raise ConfigNetworkError(ne.ERR_LOST_CONNECTION,
Line 1435:                                              'connectivity check failed')
Line 1436:         except:


--
To view, visit http://gerrit.ovirt.org/8885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list