Change in vdsm[master]: Extract bonding options building into a separate function.

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Thu Jan 17 02:58:52 UTC 2013


Mark Wu has posted comments on this change.

Change subject: Extract bonding options building into a separate function.
......................................................................


Patch Set 6: (1 inline comment)

....................................................
File vdsm/configNetwork.py
Line 1314: def _buildBondOptions(bondName, bondings):
Line 1315:     logger = logging.getLogger("_buildBondOptions")
Line 1316: 
Line 1317:     # We need to use the newest host info
Line 1318:     _ni = netinfo.NetInfo()
This function is called after bonding update, so it expects a fresh netinfo instance. This code existing in the original code. I just split it from the setupNetwork function.
Line 1319: 
Line 1320:     bond = {}
Line 1321:     if bondings.get(bondName):
Line 1322:         bond['nics'] = bondings[bondName]['nics']


--
To view, visit http://gerrit.ovirt.org/8885
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77fefefcefa05f5bd0d7fa2755357d88b7aa615e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky at redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server


More information about the vdsm-patches mailing list