Change in vdsm[master]: vdsm: Handling topology for ppc64

ybronhei at redhat.com ybronhei at redhat.com
Tue Dec 17 12:56:12 UTC 2013


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: Handling topology for ppc64
......................................................................


Patch Set 8:

(2 comments)

....................................................
File vdsm/ppc64HardwareInfo.py
Line 55: def getCpuTopology(capabilities):
Line 56:     topology = {}
Line 57: 
Line 58:     if capabilities is None:
Line 59:         retcode, out, err = utils.execCmd(['lscpu'], raw=True)
why did you remove the getLsCpu() ? i preferred as it was, just recommended to put it in utils.py
Line 60:         capabilities = out
Line 61: 
Line 62:     corePS = None
Line 63:     threadsPC = None


Line 74:             threadsPC = int(value)
Line 75:         elif key == 'Core(s) per socket':
Line 76:             corePS = int(value)
Line 77: 
Line 78:     if (corePS is not None
just put-> if corePS and threadPC and socket: ...
Line 79:             and threadsPC is not None
Line 80:             and sockets is not None):
Line 81:         topology['sockets'] = sockets
Line 82:         topology['cores'] = corePS * sockets


-- 
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list