Change in vdsm[master]: vdsm: Handling topology for ppc64

vitor.lima at eldorado.org.br vitor.lima at eldorado.org.br
Tue Dec 17 13:02:14 UTC 2013


Vitor de Lima has posted comments on this change.

Change subject: vdsm: Handling topology for ppc64
......................................................................


Patch Set 8: -Verified

(1 comment)

....................................................
File vdsm/ppc64HardwareInfo.py
Line 55: def getCpuTopology(capabilities):
Line 56:     topology = {}
Line 57: 
Line 58:     if capabilities is None:
Line 59:         retcode, out, err = utils.execCmd(['lscpu'], raw=True)
The getLsCpu() did exactly the same thing as the utils.execCmd(...), so I thought it would be a good idea to reuse this code.
Line 60:         capabilities = out
Line 61: 
Line 62:     corePS = None
Line 63:     threadsPC = None


-- 
To view, visit http://gerrit.ovirt.org/19875
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I048d4a6c083392d63fbcff76453e682b9d6f03fc
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedrosa at eldorado.org.br>
Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianconi at eldorado.org.br>
Gerrit-Reviewer: Vitor de Lima <vitor.lima at eldorado.org.br>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list