Change in vdsm[master]: hsm: refresh pool connection on connectStoragePool

danken at redhat.com danken at redhat.com
Thu Dec 19 13:03:06 UTC 2013


Dan Kenigsberg has posted comments on this change.

Change subject: hsm: refresh pool connection on connectStoragePool
......................................................................


Patch Set 4:

(1 comment)

....................................................
File vdsm/storage/hsm.py
Line 1016:     @staticmethod
Line 1017:     def _updateStoragePool(pool, hostId, msdUUID, masterVersion):
Line 1018:         if hostId != pool.id:
Line 1019:             raise se.StoragePoolConnected(
Line 1020:                 "hostId=%s, newHostId=%s" % (pool.id, hostId))
Any comment should be addressed.
Line 1021: 
Line 1022:         pool.refresh(msdUUID, masterVersion)
Line 1023: 
Line 1024:     def _connectStoragePool(self, spUUID, hostID, scsiKey, msdUUID,


-- 
To view, visit http://gerrit.ovirt.org/22467
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46d7c36b48f5d58edbc89947ccd2bcd60408a729
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list