Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Sun May 13 07:07:33 UTC 2012


Royce Lv has posted comments on this change.

Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File vdsm/libvirtvm.py
Line 153:                                 'flush_total_time_ns':devStats('flush_total_time_ns', 0)}
This is changed because I got this error when testing recovering vm patch,
in this case libvirt and qemu has not got flush_operations stats:
Thread-55::ERROR::2012-05-10 13:32:04,328::utils::399::vm.Vm::(collect)
vmId=`f7c1b02f-b304-4e68-8565-3659b1214cb3`::Stats function failed:
<AdvancedStatsFunction _sampleDiskLatency at 0x23e8f10>

Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 395,in collect
statsFunction()
File "/usr/lib/python2.7/site-packages/vdsm/utils.py", line 272, in __call__
retValue = self._function(*args, **kwargs)
File "/usr/share/vdsm/libvirtvm.py", line 163, in _sampleDiskLatency
stats = _blockstatsParses(out)
File "/usr/share/vdsm/libvirtvm.py", line 150, in _blockstatsParses
'flush_op':devStats['flush_operations'],

--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list