Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...

wudxw at linux.vnet.ibm.com wudxw at linux.vnet.ibm.com
Mon May 14 05:28:10 UTC 2012


Mark Wu has posted comments on this change.

Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................


Patch Set 2: (1 inline comment)

I am not sure if it's a real issue before I get the information asked in the inline comments. So leave it as no score.

....................................................
File vdsm/libvirtvm.py
Line 153:                                 'flush_total_time_ns':devStats('flush_total_time_ns', 0)}
It seems the traceback was truncated. I just assume it throws key error on 'flush_operations'. Disk latency report including(flush) was added in qemu-kvm-0.12.1.2-2.189.el6 (Please see https://bugzilla.redhat.com/show_bug.cgi?id=715017 for more details)
And the commit introducing this function also requires that qemu-kvm version should be above 0.12.1.2-2.189.el6 ( Please see vdsm git commit 33ef12b3f3d510ed495fd9aa8b81f11e6c04941b).

So could you please check your qemu-kvm version and report how to reproduce it?
Thanks.

--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list