Change in vdsm[master]: void _blockstatsParses throw exception when lacking some fie...

lvroyce at linux.vnet.ibm.com lvroyce at linux.vnet.ibm.com
Sun May 13 07:04:26 UTC 2012


Royce Lv has posted comments on this change.

Change subject: void _blockstatsParses throw exception when lacking some fields
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/libvirtvm.py
Line 155:                                     'flush_total_time_ns':devStats['flush_total_time_ns']}
Mark, actually this stats is vdsm call libvirt call qemu to get the stats, in some of my test case the flush_ops stats can't be got from qemu. I believe even when qemu not got this stats in some condition or because of some err, vdsm should not throw a exception.

....................................................
File vdsm/storage/hsm.py
Line 317:                 self.log.info("lvroyce find storage pool file")
sorry for introduce my personal log mistakenly:(

--
To view, visit http://gerrit.ovirt.org/4304
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id898b1456d874b1a02f04115e285e329eb1c81e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Royce Lv <lvroyce at linux.vnet.ibm.com>
Gerrit-Reviewer: Mark Wu <wudxw at linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list