Change in vdsm[master]: add functional test for vdsm sos plugin

Xu He Jie xuhj at linux.vnet.ibm.com
Sun Jun 10 02:56:49 UTC 2012


Xu He Jie has posted comments on this change.

Change subject: add functional test for vdsm sos plugin
......................................................................


Patch Set 1: (3 inline comments)

I had added a decorator '@testValidation.ValidateRunningAsRoot' for this test. Is that your mean?

....................................................
File tests/functional/sosPluginTests.py
Line 28: TMP_DIR = "/tmp"
Done

Line 40:         ret = p.poll()
Done

Line 51:         sosArchs = glob.glob(TMP_DIR + "/sosreport-" + ARCHIVE_NAME + "-*")
sosreport has another argument '--ticket-number', I also can add timestamp to it. I will chose better way for this later.

--
To view, visit http://gerrit.ovirt.org/5151
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffdab8f0b7a9ee1376591a3503e3f363cd9b97aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list