Change in vdsm[master]: add functional test for vdsm sos plugin

danken at redhat.com danken at redhat.com
Fri Jun 8 15:44:00 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: add functional test for vdsm sos plugin
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(3 inline comments)

thanks for the new test. I think you should assert that you run as root first (not sure).

....................................................
File tests/functional/sosPluginTests.py
Line 28: TMP_DIR = "/tmp"
some people do not have /tmp. better trust tempfile to do the right thing.

Line 40:         ret = p.poll()
using poll() is misleading, since communicate returns only when the process ends.
check returncode instead.

Line 51:         sosArchs = glob.glob(TMP_DIR + "/sosreport-" + ARCHIVE_NAME + "-*")
this cleanup seems too aggressive - you may delete stuff you did not create.

either use a new empty tmp directoy, or parse the output of sosreport to find the new archive name.

--
To view, visit http://gerrit.ovirt.org/5151
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffdab8f0b7a9ee1376591a3503e3f363cd9b97aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list