Change in vdsm[master]: add functional test for vdsm sos plugin

danken at redhat.com danken at redhat.com
Sun Jun 10 06:05:33 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: add functional test for vdsm sos plugin
......................................................................


Patch Set 1: (1 inline comment)

oops, I've miss that you already run as root.

....................................................
File tests/functional/sosPluginTests.py
Line 51:         sosArchs = glob.glob(TMP_DIR + "/sosreport-" + ARCHIVE_NAME + "-*")
if you use your newly-generated temp dir, you can clean it completely, and not care about the filename at all.

--
To view, visit http://gerrit.ovirt.org/5151
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iffdab8f0b7a9ee1376591a3503e3f363cd9b97aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Xu He Jie <xuhj at linux.vnet.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Xu He Jie <xuhj at linux.vnet.ibm.com>


More information about the vdsm-patches mailing list