Change in vdsm[master]: A new method to read from VMs' channels.

danken at redhat.com danken at redhat.com
Thu Jan 5 20:51:09 UTC 2012


Dan Kenigsberg has posted comments on this change.

Change subject: A new method to read from VMs' channels.
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(3 inline comments)

....................................................
File vdsm/clientIF.py
Line 119:         self.channelListener = Listener(self.log)
is this expected to be used outside clientIF? if not, keep _private.

on a second thought, believe that it would be even nicer to hide this singleton litenter inside guestIF, and create it automatically on first creation of a guestIF().

....................................................
File vdsm/vmChannels.py
Line 59:         now = int(time.time())
repeat - why on earth would we want to introduce this (up to) 1 sec rounding error?

Line 111:             read_callback, timeout_callback, param)
ignoring comments does not make them go away...

--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list