Change in vdsm[master]: A new method to read from VMs' channels.

ghammer at redhat.com ghammer at redhat.com
Sun Jan 8 08:49:07 UTC 2012


Gal Hammer has posted comments on this change.

Change subject: A new method to read from VMs' channels.
......................................................................


Patch Set 2: (3 inline comments)

....................................................
File vdsm/clientIF.py
Line 119:         self.channelListener = Listener(self.log)
Yes. It it accessible by all guestIF instances.

This is not a singleton.

....................................................
File vdsm/vmChannels.py
Line 59:         now = int(time.time())
Because I don't care about milliseconds resolution?

Line 111:             read_callback, timeout_callback, param)
Sure it does. I don't see it now.

Is changing the "param" to "opaque" is good enough?

--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list