Change in vdsm[master]: A new method to read from VMs' channels.
ghammer at redhat.com
ghammer at redhat.com
Thu Jan 5 09:42:46 UTC 2012
Gal Hammer has posted comments on this change.
Change subject: A new method to read from VMs' channels.
......................................................................
Patch Set 1: (8 inline comments)
....................................................
Commit Message
Line 11: VMs' channels.
Done
....................................................
File vdsm/clientIF.py
Line 189: self.channelListener.join()
Done
....................................................
File vdsm/guestIF.py
Line 50: def __init__(self, socketName, channelListener, log, user='Unknown', ips='', connect=True):
Done
Line 77: # Timeouts are handled in the channels' listener.
Because I touched it when trying to connect.
Line 85: logging.debug("Connection attempt failed: %s", e)
I don't agree. I don't care about the call stack here, just the reason for the connection failure.
Line 228: def _onChannelRead(self):
I don't understand. This method is called only by the VmChannel.Listener's thread.
....................................................
File vdsm/libvirtvm.py
Line 1019: self.guestAgent = guestIF.GuestAgent(self._guestSocektFile, self.cif.channelListener,
You can't blame me for anything bad happens to you! :-P
Done.
....................................................
File vdsm/Makefile.am
Line 38:
Done
--
To view, visit http://gerrit.ovirt.org/869
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I687a22a3fba6c1d2b42e837c5f2024aee0a98bdc
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>
More information about the vdsm-patches
mailing list