Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

fsimonce at redhat.com fsimonce at redhat.com
Wed Feb 15 16:53:48 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 5: (2 inline comments)

....................................................
File vdsm/storage/sp.py
Line 1038:                     # TODO: For backward compatibility VDSM is silently
The TODO was to remove this check in the future. I'll state that in a clear way (and apparently in the right place: detachSD).

Line 1043:                     return
Edu? Didn't you say we had to ignore deactivateSD?

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list