Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

abaron at redhat.com abaron at redhat.com
Wed Feb 15 16:39:46 UTC 2012


Ayal Baron has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 5: I would prefer that you didn't submit this

(4 inline comments)

....................................................
File vdsm/storage/sp.py
Line 951:         # Check if the domain is attached (inactive)
The comment has nothing to do with the check

Line 960:         detachingISO = dom.isISO()
why store the value?
i.e. why not:
if dom.isISO():

Line 1038:                     # TODO: For backward compatibility VDSM is silently
why is this 'TODO'?

Line 1043:                     return
This is the wrong behaviour.
We should ignore detaching of the master domain, not deactivate.

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list