Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

ewarszaw at redhat.com ewarszaw at redhat.com
Wed Feb 15 18:26:25 UTC 2012


Eduardo has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 6: I would prefer that you didn't submit this

(3 inline comments)

Discussed by IRC

....................................................
File vdsm/storage/sp.py
Line 955:             # raise se.CannotDetachMasterStorageDomain(sdUUID)
The future is not determined yet.

Line 961: 
validateAttachedDomain is imprescindible here.

Oh my...

Line 971:             if dom.isISO():
The value was to avoid acces twice the metadata

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list