Change in vdsm[master]: BZ#790014 Fix multiple issues in detachSD

fsimonce at redhat.com fsimonce at redhat.com
Wed Feb 15 14:21:20 UTC 2012


Federico Simoncelli has posted comments on this change.

Change subject: BZ#790014 Fix multiple issues in detachSD
......................................................................


Patch Set 4: (1 inline comment)

....................................................
File vdsm/storage/sp.py
Line 961:             raise se.StorageDomainActive(sdUUID)
953 is needed to check dom.isISO() later on

957 validateAttachedDomain() can be done in StoragePool only since it would be really tricky to do it in StorageDomain.detach() (and it shouldn't be done in forcedDetach)

954 if we need validateAttachedDomain(), then we need this line too

960-961 wiill become something like sdUUID != self.masterDomain.sdUUID

--
To view, visit http://gerrit.ovirt.org/1876
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04a7c16df86b828c514daab34f21e352919217f9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Adam Litke <agl at us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>


More information about the vdsm-patches mailing list