Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

Gal Hammer ghammer at redhat.com
Thu Aug 11 07:46:30 UTC 2011


Gal Hammer has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File vdsm/guestIF.py
Line 71:         elif message == 'power-down': # XXX: message is not send.
I can either delete the code, or try to send this message from the guest. Question is does vdsm need this message?

Line 85:             self.guestInfo['guestIPs'] = _filterXmlChars(ips)
The agent is sending a dictionary with more fields (inet6 and macc addr). Since vdsm doesn't handle these I can't just "join" the args.

Line 90:             self.guestInfo['appsList'] = apps
Yes, it does.

Line 113:             self.log.debug("Ignoring disks usages information...")
Sure we do.

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list