Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

danken at redhat.com danken at redhat.com
Wed Aug 10 19:28:14 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(6 inline comments)

partial review.. too tired atm.

....................................................
File vdsm/clientIF.py
Line 272
let's kill it from the client, too.

hmmm. unless we want to keep it as a debug tool?

....................................................
File vdsm/guestIF.py
Line 71:         elif message == 'power-down': # XXX: message is not send.
send. --> is never sent by any guest
(any reason to keep it around? I drop it in a different patch)

Line 85:             self.guestInfo['guestIPs'] = _filterXmlChars(ips)
' '.join(args['interfaces']) ?

Line 90:             self.guestInfo['appsList'] = apps
map(_filterXmlChars, args['applications'])
is nicer imo.

Line 113:             self.log.debug("Ignoring disks usages information...")
wouldn't we want to report them in guestInfo[diskUsage]  instead?
yeah, another patch.

Line 203:         
ETRAILINGSPACE

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>


More information about the vdsm-patches mailing list