Change in vdsm[master]: A new JSON-based protocol with the guest's agent.

danken at redhat.com danken at redhat.com
Wed Aug 17 05:53:02 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: A new JSON-based protocol with the guest's agent.
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/guestIF.py
Line 71:         elif message == 'power-down': # XXX: message is not send.
I don't know what it was supposed to do, but fact is that we surrvive without it for several releases. I'd drop it, in a separate patch, with an explanation why.

Line 85:             self.guestInfo['guestIPs'] = _filterXmlChars(ips)
' '.join(iface['inet'] for iface in args['interfaces'] )

--
To view, visit http://gerrit.usersys.redhat.com/807
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6096b326cc58879c8f63b72e32586657fffeca0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer <ghammer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list