Change in vdsm[master]: vdsm: bz#727871: rewrote the messages handling code.

danken at redhat.com danken at redhat.com
Thu Aug 4 08:40:22 UTC 2011


Dan Kenigsberg has posted comments on this change.

Change subject: vdsm: bz#727871: rewrote the messages handling code.
......................................................................


Patch Set 1: (3 inline comments)

....................................................
File vdsm/guestIF.py
Line 257:     def _readMessages(self):
I find _readMessages() confusing. it does not return messages - it just fills in the buffer.

Line 261:                 self._agentTimestamp = time.time()
my problem is that you update the timestamp even if s=='', which happens when the guest agent is kill and its socket closed.

Line 284:             time.sleep(1)
afair, it is meant to deal with a broken socket.

--
To view, visit http://10.35.18.144/785
To unsubscribe, visit http://10.35.18.144/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c2ef7f08cadd686329a280c06f7db438f667db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list