Change in vdsm[master]: vdsm: bz#727871: rewrote the messages handling code.

Gal Hammer ghammer at redhat.com
Thu Aug 4 08:50:57 UTC 2011


Gal Hammer has posted comments on this change.

Change subject: vdsm: bz#727871: rewrote the messages handling code.
......................................................................


Patch Set 1: (2 inline comments)

....................................................
File vdsm/guestIF.py
Line 257:     def _readMessages(self):
And _readBuffer() doesn't return buffer :-)

Back in the old days you declared on either a function or a procedure. I miss Pascal...

Line 284:             time.sleep(1)
Then it should move to the _readMessages function, no? If recv returns None, sleep and then try to recv again.

--
To view, visit http://10.35.18.144/785
To unsubscribe, visit http://10.35.18.144/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c2ef7f08cadd686329a280c06f7db438f667db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list