Change in vdsm[master]: vdsm: bz#727871: rewrote the messages handling code.

Gal Hammer ghammer at redhat.com
Thu Aug 4 08:29:33 UTC 2011


Gal Hammer has posted comments on this change.

Change subject: vdsm: bz#727871: rewrote the messages handling code.
......................................................................


Patch Set 1: (4 inline comments)

....................................................
File vdsm/guestIF.py
Line 257:     def _readMessages(self):
I don't think so. You don't read "buffer", you read "messages" that will be parsed. But if you insist on renaming the function, how about _readFromChannel?

Line 261:                 self._agentTimestamp = time.time()
Yes. I assume that if the recv is successful then the agent is responsive. Updating when messages are parsed will just update the time stamp several times with the same value.

Line 269:         self._buffer += s
I guess not.

Line 284:             time.sleep(1)
Isn't the sleep is redundant then?

--
To view, visit http://10.35.18.144/785
To unsubscribe, visit http://10.35.18.144/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id3c2ef7f08cadd686329a280c06f7db438f667db
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Gal Hammer <ghammer at redhat.com>


More information about the vdsm-patches mailing list