Review Request 78: openlmi-networking [2/8] Support for Mode argument in ApplySettingToIPNetworkConnection

Jan Safranek reviewboard at gallagherhome.com
Thu Mar 28 15:40:59 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard-openlmi.rhcloud.com/r/78/#review78
-----------------------------------------------------------



src/connection.c
<http://reviewboard-openlmi.rhcloud.com/r/78/#comment47>

    Local variable should be enough, no need fo malloc/free.


- Jan Safranek


On March 28, 2013, 3:06 p.m., Radek Novacek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard-openlmi.rhcloud.com/r/78/
> -----------------------------------------------------------
> 
> (Updated March 28, 2013, 3:06 p.m.)
> 
> 
> Review request for OpenLMI Developers.
> 
> 
> Repository: openlmi-networking
> 
> 
> Description
> -------
> 
> Support for Mode argument in ApplySettingToIPNetworkConnection
> 
> Mode argument is use to differentiate between applying connection
> immediatelly and setting it as default.
> 
> 
> Diffs
> -----
> 
>   mof/LMI_Networking.mof 61a0bff26e0b879ea9c986449419686124898562 
>   src/LMI_IPConfigurationServiceProvider.c a98132789a36bed7837f9b23872eaeb84d5c2c8d 
>   src/connection.h 8ebb4dd04bb135e6fa94f0dd3a4ac32b77a983c2 
>   src/connection.c 31dd820014483760277fc1118ad9839531cc4260 
>   src/connection_nm.c 65dcaa989b7585c7bf1eba1b6a992e1122ad9b6d 
>   src/connection_private.h b3304d6764784d0d2fff64147c419362aed58816 
>   src/errors.h 49a58cd1434d70cf4266536a326c3bbeaaf37899 
>   src/network.h 2ebfb7fd3211790702980ec6eb182075675a880d 
>   src/network.c 8aca260a7428f59d77a0f4cb717eb07719c3a97e 
>   src/port.h 1498aa5efc72ba86dfe5cebbefe6e565b8cef590 
>   src/port.c ba6944dcbf9d4dd91567825937c23391e2e14bbb 
>   src/port_nm.c 7e72aa3510933f5b87674297dcebbaf87295e35b 
>   src/port_private.h b20b176b47e1878a47a49477b8c719f016250d8c 
>   src/unittest/mock_nm.c 5a3cea46788c74c5b654aeb73bc1b6154425b27b 
>   src/unittest/test_connection.c b5f2e37bad9c0ce87b0bc6b91b63f45605fb24a8 
>   src/unittest/test_network.c c2989b6f881a96976883ceabdaebc392f0016b84 
>   test/test_apply_connection.py PRE-CREATION 
>   test/test_create_destroy_connection.py a68d32bc39cbd703884315e9fd594228ebc59522 
> 
> Diff: http://reviewboard-openlmi.rhcloud.com/r/78/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Radek Novacek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fedorahosted.org/pipermail/openlmi-devel/attachments/20130328/fecc3f01/attachment.html>


More information about the openlmi-devel mailing list