<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://reviewboard-openlmi.rhcloud.com/r/78/">http://reviewboard-openlmi.rhcloud.com/r/78/</a>
     </td>
    </tr>
   </table>
   <br />











<div>




<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="http://reviewboard-openlmi.rhcloud.com/r/78/diff/1/?file=414#file414line82" style="color: black; font-weight: bold; text-decoration: underline;">src/connection.c</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>



 
 

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
    <th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">82</font></th>
    <td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span class="n">Connection</span> <span class="o">*</span><span class="n">new_connection</span> <span class="o">=</span> <span class="n">malloc</span><span class="p">(</span><span class="k">sizeof</span><span class="p">(</span><span class="n">Connection</span><span class="p">));</span></pre></td>
  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Local variable should be enough, no need fo malloc/free.</pre>
</div>
<br />



<p>- Jan</p>


<br />
<p>On March 28th, 2013, 3:06 p.m. CET, Radek Novacek wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://reviewboard-openlmi.rhcloud.com/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for OpenLMI Developers.</div>
<div>By Radek Novacek.</div>


<p style="color: grey;"><i>Updated March 28, 2013, 3:06 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
openlmi-networking
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Support for Mode argument in ApplySettingToIPNetworkConnection

Mode argument is use to differentiate between applying connection
immediatelly and setting it as default.
</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>mof/LMI_Networking.mof <span style="color: grey">(61a0bff26e0b879ea9c986449419686124898562)</span></li>

 <li>src/LMI_IPConfigurationServiceProvider.c <span style="color: grey">(a98132789a36bed7837f9b23872eaeb84d5c2c8d)</span></li>

 <li>src/connection.h <span style="color: grey">(8ebb4dd04bb135e6fa94f0dd3a4ac32b77a983c2)</span></li>

 <li>src/connection.c <span style="color: grey">(31dd820014483760277fc1118ad9839531cc4260)</span></li>

 <li>src/connection_nm.c <span style="color: grey">(65dcaa989b7585c7bf1eba1b6a992e1122ad9b6d)</span></li>

 <li>src/connection_private.h <span style="color: grey">(b3304d6764784d0d2fff64147c419362aed58816)</span></li>

 <li>src/errors.h <span style="color: grey">(49a58cd1434d70cf4266536a326c3bbeaaf37899)</span></li>

 <li>src/network.h <span style="color: grey">(2ebfb7fd3211790702980ec6eb182075675a880d)</span></li>

 <li>src/network.c <span style="color: grey">(8aca260a7428f59d77a0f4cb717eb07719c3a97e)</span></li>

 <li>src/port.h <span style="color: grey">(1498aa5efc72ba86dfe5cebbefe6e565b8cef590)</span></li>

 <li>src/port.c <span style="color: grey">(ba6944dcbf9d4dd91567825937c23391e2e14bbb)</span></li>

 <li>src/port_nm.c <span style="color: grey">(7e72aa3510933f5b87674297dcebbaf87295e35b)</span></li>

 <li>src/port_private.h <span style="color: grey">(b20b176b47e1878a47a49477b8c719f016250d8c)</span></li>

 <li>src/unittest/mock_nm.c <span style="color: grey">(5a3cea46788c74c5b654aeb73bc1b6154425b27b)</span></li>

 <li>src/unittest/test_connection.c <span style="color: grey">(b5f2e37bad9c0ce87b0bc6b91b63f45605fb24a8)</span></li>

 <li>src/unittest/test_network.c <span style="color: grey">(c2989b6f881a96976883ceabdaebc392f0016b84)</span></li>

 <li>test/test_apply_connection.py <span style="color: grey">(PRE-CREATION)</span></li>

 <li>test/test_create_destroy_connection.py <span style="color: grey">(a68d32bc39cbd703884315e9fd594228ebc59522)</span></li>

</ul>

<p><a href="http://reviewboard-openlmi.rhcloud.com/r/78/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>