Review Request 78: openlmi-networking [2/8] Support for Mode argument in ApplySettingToIPNetworkConnection

Tomáš Smetana tsmetana at redhat.com
Fri Mar 29 08:40:20 UTC 2013


On Fri, 29 Mar 2013 06:44:30 -0000
Radek Novacek <reviewboard at gallagherhome.com> wrote:

> 
> 
> > On March 28, 2013, 3:36 p.m., Tomas Smetana wrote:
> > > src/connection.c, lines 80-90
> > > <http://reviewboard-openlmi.rhcloud.com/r/78/diff/1/?file=414#file414line80>
> > >
> > >     Line 82: malloc can return NULL. And looking at the function:
> > > what's the point of the dynamic allocation of the new_connection anyway?
> 
> The original connection (first argument) will be updated from DBus signal
> when the change is done in NetworkManager. The original state of connection
> would be lost if the connection update fails. Is it clear or should I
> explain it more?
> 
> In this case it could be easily reverted but this is intended as universal
> mechanism.

Heh. A misunderstanding... I know why we needed the new_connection. I wasn't
sure why it had to be allocated dynamically. Since you fixed that after Jan's
review, I think there's nothing more to see here. :)

Thanks and regards,
-- 
Tomáš Smetana
Platform Engineering, Red Hat


More information about the openlmi-devel mailing list