Patch review for OpenLMI

Stephen Gallagher sgallagh at redhat.com
Tue Mar 12 12:35:46 UTC 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue 12 Mar 2013 08:31:15 AM EDT, Jan Safranek wrote:
> On 03/12/2013 12:31 PM, Stephen Gallagher wrote:
>> I've used Review Board, Gerrit and Github on multiple occasions,
>> and without any doubt I will say that Review Board has the most 
>> comprehensive, powerful and easy to use *review* interface.
>> Gerrit has the best merge interface (and a terrible review
>> interface) and Github is kind of mediocre on both points.
> 
> <snip>
> 
>> So yes, if we opt for Review Board, we're still going to be
>> doing manual merges to the upstream repository. I don't
>> necessarily think that's a bad thing, since it requires a final
>> manual step to make sure that nothing obviously breaks (although
>> this can be minimized with continuous integration testing).
> 
> I have direct experience only with GitHub and hasn't been pleasant
> so far. I trust your experience and I'd vote for Review Board. Only
> time shows if it is good tool.
> 
> BTW, reading mediawiki's Gerrit_evaluation, I am quite surprised it
> does not allow review of patch series. I usually have multiple
> patches in one branch, I polish them and then I send whole patchset
> for review, does Review Board support this?
> 


No, not yet. It's under active development as part of Review Board 2.0
(hopefully coming out in late 2013). I'm on the planning team for that
feature (mostly because I put myself there and won't shut up about it :) )

Some background on the topic:
https://groups.google.com/d/msg/reviewboard-dev/7ungX3jLoXk/PLN5Nx3KwrIJ
(It's fallen off in discussion in the last couple months, mostly due
to the release of 1.7 and other distractions. I need to bring that
thread back to life). I've also had some private discussions with the
upstream lead on the topic that should probably be summarized there...
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iEYEARECAAYFAlE/ISIACgkQeiVVYja6o6NzBwCgoz1ezr+3GP5x4aQPBqibT3EU
a74AoJ9LWIN35RWEuXvPu/B5KArBD4TJ
=zdmm
-----END PGP SIGNATURE-----


More information about the openlmi-devel mailing list