[PATCH 3/4] Clean up the pylint-false-positives.

David Shea dshea at redhat.com
Mon Jan 13 20:04:25 UTC 2014


Remove several false positives that don't apply anymore. Added a false
positive for get_property, since we handle set_property here, and split
the set_.* test into explicit checks for set_property and set_padding so
that it's less likely to ignore a real problem.
---
 tests/pylint/pylint-false-positives | 9 +++------
 widgets/python/AnacondaWidgets.py   | 2 --
 2 files changed, 3 insertions(+), 8 deletions(-)

diff --git a/tests/pylint/pylint-false-positives b/tests/pylint/pylint-false-positives
index d93a070..e06680a 100644
--- a/tests/pylint/pylint-false-positives
+++ b/tests/pylint/pylint-false-positives
@@ -3,12 +3,9 @@
 ^E0611:[ 0-9]*,[0-9]*:.*: No name '.*' in module 'gi.repository'$
 ^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'add' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'remove' member$
-^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'set_.*' member$
+^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'get_property' member$
+^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'set_property' member$
+^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'set_padding' member$
 ^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'show_all' member$
-^W0402:[ 0-9]*,[0-9]*: Uses of a deprecated module 'string'$
-^W0402:[ 0-9]*,[0-9]*:.*: Uses of a deprecated module 'string'$
 ^E0611:[ 0-9]*,[0-9]*: No name '_isys' in module 'pyanaconda'$
 ^E0611:[ 0-9]*,[0-9]*:.*: No name '_isys' in module 'pyanaconda'$
-^E1101:[ 0-9]*,[0-9]*:.*: Instance of '.*' has no 'anaconda' member$
-^E1101:[ 0-9]*,[0-9]*:Anaconda\.backend: Instance of 'DefaultInstall' has no 'getBackend' member$
-^dm.c: [ 0-9]*,[0-9]*: not running as root returning empty list$
diff --git a/widgets/python/AnacondaWidgets.py b/widgets/python/AnacondaWidgets.py
index 649be1c..54c6240 100644
--- a/widgets/python/AnacondaWidgets.py
+++ b/widgets/python/AnacondaWidgets.py
@@ -45,8 +45,6 @@ class MountpointSelector(Anaconda.MountpointSelector):
 
     @property
     def size(self):
-        # using get_property causes problems with pylint for some reason
-        # pylint: disable-msg=E1101
         return self.get_property("size")
 
     @size.setter
-- 
1.8.5.2



More information about the anaconda-patches mailing list