[PATCH 2/4] Remove pylint comments that are no longer necessary
David Shea
dshea at redhat.com
Mon Jan 13 20:04:24 UTC 2014
The current version of pylint does a better job with function decorators
and with gobject-introspection, so some of the disable-msg comments are
unneeded now.
---
pyanaconda/bootloader.py | 8 --------
pyanaconda/packaging/yumpayload.py | 1 -
pyanaconda/ui/gui/spokes/welcome.py | 1 -
pyanaconda/ui/tui/simpleline/base.py | 1 -
tests/storage/cases/bz1014545.py | 1 -
5 files changed, 12 deletions(-)
diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
index dfc0692..2d09bd3 100644
--- a/pyanaconda/bootloader.py
+++ b/pyanaconda/bootloader.py
@@ -308,13 +308,11 @@ class BootLoader(object):
#
# disk list access
#
- # pylint: disable-msg=E0202
@property
def disk_order(self):
"""Potentially partial order for disks."""
return self._disk_order
- # pylint: disable-msg=E0102,E0202,E1101
@disk_order.setter
def disk_order(self, order):
log.debug("new disk order: %s", order)
@@ -340,7 +338,6 @@ class BootLoader(object):
#
# image list access
#
- # pylint: disable-msg=E0202
@property
def default(self):
"""The default image."""
@@ -349,7 +346,6 @@ class BootLoader(object):
return self._default_image
- # pylint: disable-msg=E0102,E0202,E1101
@default.setter
def default(self, image):
if image not in self.images:
@@ -758,7 +754,6 @@ class BootLoader(object):
def has_windows(self, devices):
return False
- # pylint: disable-msg=E0202
@property
def timeout(self):
"""Bootloader timeout in seconds."""
@@ -773,17 +768,14 @@ class BootLoader(object):
""" Run additional bootloader checks """
return True
- # pylint: disable-msg=E0102,E0202,E1101
@timeout.setter
def timeout(self, seconds):
self._timeout = seconds
- # pylint: disable-msg=E0202
@property
def update_only(self):
return self._update_only
- # pylint: disable-msg=E0102,E0202,E1101
@update_only.setter
def update_only(self, value):
if value and not self.can_update:
diff --git a/pyanaconda/packaging/yumpayload.py b/pyanaconda/packaging/yumpayload.py
index 5083bbe..1a1c76b 100644
--- a/pyanaconda/packaging/yumpayload.py
+++ b/pyanaconda/packaging/yumpayload.py
@@ -467,7 +467,6 @@ reposdir=%s
except RepoError:
return super(YumPayload, self).isRepoEnabled(repo_id)
- # pylint: disable-msg=W0221
@refresh_base_repo()
def updateBaseRepo(self, fallback=True, root=None, checkmount=True):
""" Update the base repo based on self.data.method.
diff --git a/pyanaconda/ui/gui/spokes/welcome.py b/pyanaconda/ui/gui/spokes/welcome.py
index 78cdd96..64f6adb 100644
--- a/pyanaconda/ui/gui/spokes/welcome.py
+++ b/pyanaconda/ui/gui/spokes/welcome.py
@@ -247,7 +247,6 @@ class WelcomeLanguageSpoke(LangLocaleHandler, StandaloneSpoke):
self._origStrings[welcomeLabel] = welcomeLabel.get_label()
before = self._origStrings[welcomeLabel]
- # pylint: disable-msg=E1103
xlated = _(before) % {"name" : productName.upper(), "version" : productVersion}
welcomeLabel.set_label(xlated)
diff --git a/pyanaconda/ui/tui/simpleline/base.py b/pyanaconda/ui/tui/simpleline/base.py
index 7335426..eae5c48 100644
--- a/pyanaconda/ui/tui/simpleline/base.py
+++ b/pyanaconda/ui/tui/simpleline/base.py
@@ -575,7 +575,6 @@ class UIScreen(object):
for w in self._window:
if hasattr(w, "render"):
- # pylint: disable-msg=E1101
w.render(self.app.width)
if isinstance(w, Widget):
self._print_long_widget(w)
diff --git a/tests/storage/cases/bz1014545.py b/tests/storage/cases/bz1014545.py
index 364aeb3..e0e5270 100644
--- a/tests/storage/cases/bz1014545.py
+++ b/tests/storage/cases/bz1014545.py
@@ -17,7 +17,6 @@
#
# Author: Chris Lumens <clumens at redhat.com>
-# pylint: disable-msg=E0611
from . import TestCase, TestCaseComponent
from pykickstart.errors import KickstartValueError
--
1.8.5.2
More information about the anaconda-patches
mailing list