[PATCH 4/4] Don't disable checks for global at the module level.

David Shea dshea at redhat.com
Mon Jan 13 20:04:26 UTC 2014


global at the module level doesn't do anything, so we actually should
check for that one.
---
 pyanaconda/flags.py       | 1 -
 tests/pylint/runpylint.sh | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/pyanaconda/flags.py b/pyanaconda/flags.py
index 428a246..dcc6f4c 100644
--- a/pyanaconda/flags.py
+++ b/pyanaconda/flags.py
@@ -220,6 +220,5 @@ def can_touch_runtime_system(msg, touch_live=False):
 
     return True
 
-global flags
 flags = Flags()
 
diff --git a/tests/pylint/runpylint.sh b/tests/pylint/runpylint.sh
index 0056053..fac9f71 100755
--- a/tests/pylint/runpylint.sh
+++ b/tests/pylint/runpylint.sh
@@ -47,10 +47,9 @@ export DISABLED_ERR_OPTIONS="--disable=E1103"
 # W0142 - Used * or ** magic
 # W0511 - Used when a warning note as FIXME or XXX is detected.
 # W0603 - Using the global statement
-# W0604 - Using the global statement at the module level
 # W0613 - Unused argument %r
 # W0614 - Unused import %s from wildcard import
-export DISABLED_WARN_OPTIONS="--disable=W0110,W0141,W0142,W0511,W0603,W0604,W0613,W0614"
+export DISABLED_WARN_OPTIONS="--disable=W0110,W0141,W0142,W0511,W0603,W0613,W0614"
 
 usage () {
   echo "usage: `basename $0` [--strict] [--help] [files...]"
-- 
1.8.5.2



More information about the anaconda-patches mailing list