[PATCH] Convert escaped spaces on cmdline to _ (#874381)

David Lehman dlehman at redhat.com
Tue Jun 18 23:55:39 UTC 2013


On Tue, 2013-06-18 at 16:36 -0700, Brian C. Lane wrote:
> From: "Brian C. Lane" <bcl at redhat.com>
> 
> We use shlex.split to parse the cmdline. This mostly works, except that
> it removes any \\ from the string instead of converting them back to \
> 
> This results in the device LABEL having x20 in it, which isn't matching
> the ID_FS_LABEL when looking for protected devices.
> 
> So, this replaces the \\x20 with _ when parsing the cmdline, which also
> matches what ID_FS_LABEL expects. This results in the usb device being
> filtered from the available disks for the install.

Filthy, but still ACK. Crappy problems breed crappy solutions.

How long do you think it'll be before udev/blkid change that underscore
business out from under us?



More information about the anaconda-patches mailing list