[PATCH] Convert escaped spaces on cmdline to _ (#874381)

Brian C. Lane bcl at redhat.com
Wed Jun 19 00:39:54 UTC 2013


On Tue, Jun 18, 2013 at 06:55:39PM -0500, David Lehman wrote:
> On Tue, 2013-06-18 at 16:36 -0700, Brian C. Lane wrote:
> > From: "Brian C. Lane" <bcl at redhat.com>
> > 
> > We use shlex.split to parse the cmdline. This mostly works, except that
> > it removes any \\ from the string instead of converting them back to \
> > 
> > This results in the device LABEL having x20 in it, which isn't matching
> > the ID_FS_LABEL when looking for protected devices.
> > 
> > So, this replaces the \\x20 with _ when parsing the cmdline, which also
> > matches what ID_FS_LABEL expects. This results in the usb device being
> > filtered from the available disks for the install.
> 
> Filthy, but still ACK. Crappy problems breed crappy solutions.

Yeah. I *am* fairly confident it won't break anything, since it wasn't
working in the first place. So that's a plus :)

> 
> How long do you think it'll be before udev/blkid change that underscore
> business out from under us?

Yeah. Although they do also have a ID_FS_LABEL_ENC which has the \\
still in it -- I was going to possibly switch to using that if shelx had
been more cooperative.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 482 bytes
Desc: not available
URL: <https://lists.fedorahosted.org/pipermail/anaconda-patches/attachments/20130618/38e513da/attachment.sig>


More information about the anaconda-patches mailing list