Yoav Kleinberger has posted comments on this change.
Change subject: tests: introducing whitebox tests
......................................................................
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/29745/4/tests/README
File tests/README:
Line 30: ----------------------
Line 31:
Line 32: Whitebox tests are somewhere in the middle between unit tests and functional
Line 33: tests (see above). A whitebox test checks functionality of a small number
Line 34: (perhaps one) of components, in the sense that these components "reall
work",
reall -> really
Done
Line 35: i.e. they actually open sockets, read files, write to storage, etc. This
Line 36: contrasts with a unit test, in which external components should be mocked. It
Line 37: also contrasts with the functional tests, in that the scope of code checked is
Line 38: much smaller, and the test is aware of the underlying implementation (hence the
Line 35: i.e. they actually open sockets, read files, write to storage, etc. This
Line 36: contrasts with a unit test, in which external components should be mocked. It
Line 37: also contrasts with the functional tests, in that the scope of code checked is
Line 38: much smaller, and the test is aware of the underlying implementation (hence the
Line 39: term "white" box, as opposed to "black" box).
so it is indeed integration test.
I don't think so. What
does it integrate? our python code with libguestfs? I wouldn't call this an
integration test. The same logic would lead you to say that using ``print" is an
integration test with libc.
Line 40:
--
To view, visit
http://gerrit.ovirt.org/29745
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes