Adam Litke has posted comments on this change.
Change subject: tests: introducing whitebox tests
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/29745/5//COMMIT_MSG
Commit Message:
Line 18: because they are aware of the inside implementation (as opposed to
Line 19: blackbox tests), but they check that things "really work" (e.g.
Line 20: libraries get called, sockets are opened, etc.) , and not just
Line 21: the internal logic of some small section of code (which would
Line 22: characterize a unit test).
I agree with another commenter that blackbox vs. whitebox isn't interesting enough in
its own right to justify all of the arguing we'd do in the future when classifying
tests. I agree that the problem you are trying to solve is valid but I would frame it
differently.
To me, there are some functional tests which are easily automated and can produce a valid
result on all supported configurations of the software. To me these are functional
tests.
We need another category for tests which require a special environment and/or are not
easily automated. We should always prefer a test to be 'functional' rather than
'special' since these special tests will not be run nearly as often. However it
is better to have 'special' tests than no test at all.
Line 23:
Line 24: Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
--
To view, visit
http://gerrit.ovirt.org/29745
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes