Dan Kenigsberg has posted comments on this change.
Change subject: tests: alignmentScanTests.py is a functional test
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/29745/1//COMMIT_MSG
Commit Message:
Line 6:
Line 7: tests: alignmentScanTests.py is a functional test
Line 8:
Line 9: Since alignmentScanTests invokes actual storage code, and does not mock
Line 10: it out, it should be categorized as a functional test.
The functional tests are special since they test the functionality of Vdsm via its API.
They require a running and responsive Vdsm instance.
This is not the case here - this module checks (actually, only SHOULD check, as it is
buggy) that and internal scanImage() function does what it should.
Line 11:
Line 12: Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
--
To view, visit
http://gerrit.ovirt.org/29745
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e20d17c3ebee1203bb5a721ce44d5867570ce8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
Gerrit-Reviewer: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes