Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm: pre-defined range for spice/vnc ports
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/23940/1/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm/tool/libvirt_configure.sh.in:
Line 155: # version. In fact the configure generated here is almost unrelated to the
Line 156: # package version, so anything meaningful can be used here. Since a hard
Line 157: # coded version string has been already used, for compatibility we will
Line 158: # continue to use this string.
Line 159: local by_vdsm_vers="4.13.0"
this is a bit annoying, as it means a libvirtd restart during a micro
versi
it can raise some troubles with my upgrade logic. lets cross fingers that we
did it alright
Line 160: local start_conf_section="## beginning of configuration section
${by_vdsm}"
Line 161: local end_conf_section="## end of configuration section
${by_vdsm}"
Line 162:
Line 163: local ts=/etc/pki/vdsm
--
To view, visit
http://gerrit.ovirt.org/23940
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes