Hello Dan Kenigsberg, Peter V. Saveliev, Michal Skrivanek,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/23940
to review the following change.
Change subject: vdsm: pre-defined range for spice/vnc ports
......................................................................
vdsm: pre-defined range for spice/vnc ports
Libvirt's default port range 5900-65535 which is out of VDSM's
documented range 5634 to 6166. But since the medieval time we
already use libvirt's default. We'll define the new range as
5900-6923 (1024 ports) So:
1. Set some limited port range, that can be used in FW conf
2. Use start port 5900 as it is already used by customers
3. Use the endport as 6923
4. Change VDSM documentation according to new port range
Bug-Url:
https://bugzilla.redhat.com/show_bug.cgi?id=1052162
Signed-off-by: Peter V. Saveliev <peet(a)redhat.com>
Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Reviewed-on:
http://gerrit.ovirt.org/17058
Reviewed-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Tested-by: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Reviewed-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/tool/libvirt_configure.sh.in
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/40/23940/1
diff --git a/lib/vdsm/tool/libvirt_configure.sh.in
b/lib/vdsm/tool/libvirt_configure.sh.in
index cf70f59..ea0500c 100755
--- a/lib/vdsm/tool/libvirt_configure.sh.in
+++ b/lib/vdsm/tool/libvirt_configure.sh.in
@@ -156,7 +156,7 @@
# package version, so anything meaningful can be used here. Since a hard
# coded version string has been already used, for compatibility we will
# continue to use this string.
- local by_vdsm_vers="4.10.3"
+ local by_vdsm_vers="4.13.0"
local start_conf_section="## beginning of configuration section
${by_vdsm}"
local end_conf_section="## end of configuration section ${by_vdsm}"
@@ -241,6 +241,10 @@
set_if_default "${lconf}" listen_tls 0
fi
+ # Configure remote display port range
+ set_if_default "${qconf}" remote_display_port_min 5900
+ set_if_default "${qconf}" remote_display_port_max 6923
+
# Configuring sanlock
if [ "${ENABLE_LIBVIRT_SANLOCK}" = "yes" ]; then
set_if_default "${qconf}" lock_manager \"sanlock\"
--
To view, visit
http://gerrit.ovirt.org/23940
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id42d41064e122f1b2dcc98506b58d0cc74239650
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.3
Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Peter V. Saveliev <peet(a)redhat.com>