Change in vdsm[master]: stomp: handle timeout in server side
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: handle timeout in server side
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/78614/1/tests/stompadapter_test.py
File tests/stompadapter_test.py:
Line 514: adapter = StompAdapterImpl(Reactor(), destinations, {})
Line 515: adapter.handle_frame(dispatcher, frame1)
Line 516: adapter.handle_frame(dispatcher, frame2)
Line 517:
Line 518: adapter.handle_timeout(dispatcher)
don't you want to test it without calling the timeout directly but let it raise..
Line 519:
Line 520: self.assertEqual(len(adapter._sub_ids), 0)
--
To view, visit https://gerrit.ovirt.org/78614
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: stomp: handle incoming heartbeats
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: handle incoming heartbeats
......................................................................
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: stomp: allow incoming heartbeats
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: allow incoming heartbeats
......................................................................
Patch Set 8:
(3 comments)
https://gerrit.ovirt.org/#/c/78218/8//COMMIT_MSG
Commit Message:
Line 8:
Line 9: Until now, we ignored incoming heartbeats and didn't
Line 10: handle them.
Line 11: This patch gets the incoming heartbeats and updates the
Line 12: dispatcher according to their value.
what value is that? is it timestamp..? im not familiar with stomp heartbeats, maybe better to put here a link that explains how hearbeat mechanism works?
Line 13: When the server stops receiving incoming heartbeats, it should
Line 14: cleanup subacriptions and close the fd.
Line 15:
Line 16: Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Line 10: handle them.
Line 11: This patch gets the incoming heartbeats and updates the
Line 12: dispatcher according to their value.
Line 13: When the server stops receiving incoming heartbeats, it should
Line 14: cleanup subacriptions and close the fd.
s/subacriptions/subscriptions
Line 15:
Line 16: Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Line 17: Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
https://gerrit.ovirt.org/#/c/78218/8/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 386: if self._incoming_heartbeat_in_milis:
Line 387: self._update_incoming_heartbeat()
Line 388:
Line 389: def handle_timeout(self):
Line 390: self._frame_handler.handle_timeout(self)
is this related?
Line 391:
Line 392: def popFrame(self):
Line 393: return self._parser.popFrame()
Line 394:
--
To view, visit https://gerrit.ovirt.org/78218
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9558ecddef3b57d37cfe4257c1c0ab4f2015064
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: tests: rename mock classes in stomp tests
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: tests: rename mock classes in stomp tests
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/78499
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I297236c0a9e81500b630892977bfbc1c930f9c46
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: net: Generate dump bonding options on boot and upgrade
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
Patch Set 23: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/78006/23/configure.ac
File configure.ac:
Line 425: tests/devices/parsing/Makefile
Line 426: tests/functional/Makefile
Line 427: tests/integration/Makefile
Line 428: tests/network/Makefile
Line 429: tests/network/static/Makefile
tab here
Line 430: tests/virttests/Makefile
Line 431: vdsm/Makefile
Line 432: vdsm/sos/Makefile
Line 433: vdsm/virt/Makefile
https://gerrit.ovirt.org/#/c/78006/23/vdsm.spec.in
File vdsm.spec.in:
Line 1333: %dir %{_datadir}/%{vdsm_name}/tests/devices/data
Line 1334: %dir %{_datadir}/%{vdsm_name}/tests/devices/parsing
Line 1335: %dir %{_datadir}/%{vdsm_name}/tests/integration
Line 1336: %dir %{_datadir}/%{vdsm_name}/tests/network
Line 1337: %dir %{_datadir}/%{vdsm_name}/tests/network/static/*
drop the trailing asterisk, and and another line for the dir files.
Line 1338: %{_datadir}/%{vdsm_name}/tests/*.py*
Line 1339: %{_datadir}/%{vdsm_name}/tests/cpu_info.out
Line 1340: %{_datadir}/%{vdsm_name}/tests/caps_libvirt_intel_E5649.out
Line 1341: %{_datadir}/%{vdsm_name}/tests/caps_libvirt_amd_6274.out
--
To view, visit https://gerrit.ovirt.org/78006
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 10 months
Change in vdsm[master]: place libvirt_password under static
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: place libvirt_password under static
......................................................................
place libvirt_password under static
Change-Id: I5c9effb4cf7499a6d6f231303ac3b46aab8ff536
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M static/Makefile.am
R static/etc/pki/vdsm/keys/libvirt_password
M vdsm/Makefile.am
3 files changed, 4 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/78548/1
diff --git a/static/Makefile.am b/static/Makefile.am
index a6851e3..73c9348 100644
--- a/static/Makefile.am
+++ b/static/Makefile.am
@@ -108,6 +108,9 @@
./etc/modprobe.d/vdsm-bonding-modprobe.conf \
$(NULL)
+libvirtpassworddir = $(vdsmtsdir)/keys
+libvirtpassword_DATA = ./$(libvirtpassworddir)/libvirt_password
+
networkmanagerdir = $(sysconfdir)/NetworkManager/conf.d
networkmanager_DATA = \
@@ -141,6 +144,7 @@
$(NULL)
EXTRA_DIST = \
+ $(libvirtpassword_DATA) \
$(limits_DATA) \
$(modprobe_DATA) \
$(modulesload_DATA) \
diff --git a/vdsm/libvirt_password b/static/etc/pki/vdsm/keys/libvirt_password
similarity index 100%
rename from vdsm/libvirt_password
rename to static/etc/pki/vdsm/keys/libvirt_password
diff --git a/vdsm/Makefile.am b/vdsm/Makefile.am
index 13b7f68..dbcde97 100644
--- a/vdsm/Makefile.am
+++ b/vdsm/Makefile.am
@@ -52,7 +52,6 @@
$(nodist_man8_MANS)
EXTRA_DIST = \
- libvirt_password \
mk_sysprep_floppy.in \
vdsm-gencerts.sh.in \
vdsm-libvirt-access.pkla \
@@ -69,7 +68,6 @@
chmod 775 $(DESTDIR)$(localstatedir)/lib/libvirt/qemu/channels
install-data-local: \
- install-data-libvirtpass \
install-data-logrotate \
install-data-vdsmconf
$(MKDIR_P) $(DESTDIR)$(vdsmrepo)
@@ -92,17 +90,8 @@
$(MKDIR_P) $(DESTDIR)$(localstatedir)/lib/libvirt/qemu/channels
uninstall-local: \
- uninstall-data-libvirtpass \
uninstall-data-logrotate \
uninstall-data-vdsmconf
-
-install-data-libvirtpass:
- $(MKDIR_P) $(DESTDIR)$(vdsmtsdir)/keys
- $(INSTALL_DATA) -m 600 $(srcdir)/libvirt_password \
- $(DESTDIR)$(vdsmtsdir)/keys/libvirt_password
-
-uninstall-data-libvirtpass:
- $(RM) $(DESTDIR)$(vdsmtsdir)/keys/libvirt_password
install-data-logrotate:
$(MKDIR_P) $(DESTDIR)$(sysconfdir)/cron.hourly
--
To view, visit https://gerrit.ovirt.org/78548
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5c9effb4cf7499a6d6f231303ac3b46aab8ff536
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 10 months
Change in vdsm[master]: tests: Remove TestCaseBase in stoarge tests
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Remove TestCaseBase in stoarge tests
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/78582
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I250f39087cc075bb1a34fda7a592cf5531737e16
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: tests: Unify storage test class names
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: tests: Unify storage test class names
......................................................................
Patch Set 2: Code-Review+2
passes CI - good enough for such a change.
--
To view, visit https://gerrit.ovirt.org/78581
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I28d84c860ef4881681be6892939d6a928fa86d34
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: utils: Remove CommandStream
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: Remove CommandStream
......................................................................
Patch Set 19: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/75011
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e4d890aeee02f0ad5e003d05579670b4d1682cc
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months
Change in vdsm[master]: virt: vmstats: use dedicated logger
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: vmstats: use dedicated logger
......................................................................
Patch Set 3: Code-Review+1
I like the simplicity of using the root logger everywhere, but I would not mind this patch.
--
To view, visit https://gerrit.ovirt.org/77996
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I49b92f25f6dbd742eef6ca05593c4821f7d56139
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 10 months