From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: handle timeout in server side
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/78614/1/tests/stompadapter_test.py
File tests/stompadapter_test.py:
Line 514: adapter = StompAdapterImpl(Reactor(), destinations, {})
Line 515: adapter.handle_frame(dispatcher, frame1)
Line 516: adapter.handle_frame(dispatcher, frame2)
Line 517:
Line 518: adapter.handle_timeout(dispatcher)
don't you want to test it without calling the timeout directly but let it raise..
Line 519:
Line 520: self.assertEqual(len(adapter._sub_ids), 0)
--
To view, visit
https://gerrit.ovirt.org/78614
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic83ccb947771e79cb08d9d9fa3b1da64d074fda5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes