From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Generate dump bonding options on boot and upgrade
......................................................................
Patch Set 23: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/78006/23/configure.ac
File configure.ac:
Line 425: tests/devices/parsing/Makefile
Line 426: tests/functional/Makefile
Line 427: tests/integration/Makefile
Line 428: tests/network/Makefile
Line 429: tests/network/static/Makefile
tab here
Line 430: tests/virttests/Makefile
Line 431: vdsm/Makefile
Line 432: vdsm/sos/Makefile
Line 433: vdsm/virt/Makefile
https://gerrit.ovirt.org/#/c/78006/23/vdsm.spec.in
File vdsm.spec.in:
Line 1333: %dir %{_datadir}/%{vdsm_name}/tests/devices/data
Line 1334: %dir %{_datadir}/%{vdsm_name}/tests/devices/parsing
Line 1335: %dir %{_datadir}/%{vdsm_name}/tests/integration
Line 1336: %dir %{_datadir}/%{vdsm_name}/tests/network
Line 1337: %dir %{_datadir}/%{vdsm_name}/tests/network/static/*
drop the trailing asterisk, and and another line for the dir files.
Line 1338: %{_datadir}/%{vdsm_name}/tests/*.py*
Line 1339: %{_datadir}/%{vdsm_name}/tests/cpu_info.out
Line 1340: %{_datadir}/%{vdsm_name}/tests/caps_libvirt_intel_E5649.out
Line 1341: %{_datadir}/%{vdsm_name}/tests/caps_libvirt_amd_6274.out
--
To view, visit
https://gerrit.ovirt.org/78006
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98f7c691a2a86d152ebcb81e1d96f9b0d83fa698
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes