Change in vdsm[master]: net: Push NetInfo object down the ifcfg setup flow
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Push NetInfo object down the ifcfg setup flow
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icddf479171b7a4d05ed803bd199831f59a7e9167
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: net: Normalize network 'ipv6addr' on netinfo to kconfig tran...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Normalize network 'ipv6addr' on netinfo to kconfig translation
......................................................................
net: Normalize network 'ipv6addr' on netinfo to kconfig translation
'ipv6addr' is being normalized on config read from a string to a list in
order to correctly compare it to kernelconfig.
It is more appropriate to perform the opposite translation, from netinfo
to the config representation.
Change-Id: Ifb1caec15d5193d272e179db6bb4e1aad8e6afc7
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/kernelconfig.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/73245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1caec15d5193d272e179db6bb4e1aad8e6afc7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: net: Normalize network 'ipv6addr' on netinfo to kconfig tran...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Normalize network 'ipv6addr' on netinfo to kconfig translation
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/73245/1/lib/vdsm/network/kernelconfig.py
File lib/vdsm/network/kernelconfig.py:
Line 101: attributes['netmask'] = net_attr['netmask']
Line 102: if net_attr['gateway']:
Line 103: attributes['gateway'] = net_attr['gateway']
Line 104: if not attributes['dhcpv6']:
Line 105: if net_attr['ipv6addrs']:
RunningConfig does not support multiple ipv6 addresses, but netinfo reports them. Choose random address and report it in KernelConfig
Line 106: # kernelconfig does not support multiple IPv6 addresses,
Line 107: # therefore a random one is chosen.
Line 108: attributes['ipv6addr'] = net_attr['ipv6addrs'][0]
Line 109: if net_attr['ipv6gateway'] != '::':
--
To view, visit https://gerrit.ovirt.org/73245
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb1caec15d5193d272e179db6bb4e1aad8e6afc7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: virt: devices: rng: declare 'address' attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: rng: declare 'address' attribute
......................................................................
virt: devices: rng: declare 'address' attribute
since we redefine __slots__, we need to declare all the attributes
we use.
Change-Id: I1faae54e8a88d7e9c67eb35cd5e5de1eec21fd73
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/70927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1faae54e8a88d7e9c67eb35cd5e5de1eec21fd73
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: virt: devices: redir: declare the 'bus' attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: devices: redir: declare the 'bus' attribute
......................................................................
virt: devices: redir: declare the 'bus' attribute
It was not included in __slots__, but we need it.
Change-Id: Ia36d1c38e466d4cf11312eb13b6d7be64fa37109
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/core.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Martin Polednik: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia36d1c38e466d4cf11312eb13b6d7be64fa37109
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: virt: devices: redir: declare the 'bus' attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: redir: declare the 'bus' attribute
......................................................................
Patch Set 5: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/72955
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia36d1c38e466d4cf11312eb13b6d7be64fa37109
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: virt: devices: rng: declare 'address' attribute
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: virt: devices: rng: declare 'address' attribute
......................................................................
Patch Set 9: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/70927
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1faae54e8a88d7e9c67eb35cd5e5de1eec21fd73
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: virt: Run job completed actions after recovered migrations
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Run job completed actions after recovered migrations
......................................................................
virt: Run job completed actions after recovered migrations
VM.onJobCompleted checks self._migrationSourceThread.started flag to know
whether the callback was invoked after a migration. However if Vdsm was
restarted during the migration, the flag is not set since the source thread is
not actually running. So in such a case onJobCompleted returns immediately
without performing the post-migration actions.
We fix it by adding a check for a recovered migration at the place. We must
also ensure that SourceThread._recovery is reset after unsuccessful migration,
otherwise the post-migration actions would be called for all subsequent domain
jobs. This doesn't work in all situations since libvirt may not notify us
after failed migrations so SourceThread._recovery gets reset only when the
migration is explicitly canceled.
Change-Id: I2eaacbfc48bee4863ec75b29e120fc5aa7b31d10
Signed-off-by: Milan Zamazal <mzamazal(a)redhat.com>
---
M lib/vdsm/virt/migration.py
M vdsm/virt/vm.py
2 files changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Milan Zamazal: Verified
--
To view, visit https://gerrit.ovirt.org/73447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2eaacbfc48bee4863ec75b29e120fc5aa7b31d10
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: vmxml: separate vmxml.Element and etree.Element
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: separate vmxml.Element and etree.Element
......................................................................
vmxml: separate vmxml.Element and etree.Element
Up until now, the vmxml.Element was quite liberal in accepting
arguments to its append*() methods; same was true for
vmxml.append_child.
We had freedom to mix and match vmxml.Element and etree.Elements
freely, without any apparent harm.
Things change in python3; if we run the very same code under python3,
for example because of the tests introduced in
patch Id1beb214e76c5173de318406fc6208990d33adbb
we get errors like
File "lib/vdsm/virt/vmxml.py", line 334, in appendChild
self._elem.append(element)
TypeError: append() argument must be xml.etree.ElementTree.Element, not Element
To fix this issue, we must always append etree Elements childs.
Confusion can arise from a couple od sources; we add a special-purpose
appendEtree method to mark such places, in order to always append
the right element.
Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Signed-off-by: Francesco Romani <fromani(a)redhat.com>
---
M lib/vdsm/virt/libvirtxml.py
M lib/vdsm/virt/vmdevices/network.py
M lib/vdsm/virt/vmxml.py
M tests/vmxml_test.py
4 files changed, 34 insertions(+), 8 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
Francesco Romani: Verified
Milan Zamazal: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: vmxml: separate vmxml.Element and etree.Element
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: vmxml: separate vmxml.Element and etree.Element
......................................................................
Patch Set 13: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72089
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60003e69702508e173703fcfa7d5ec2e0cffbd14
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months