Change in vdsm[master]: add dhclient to dependencies
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: add dhclient to dependencies
......................................................................
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/73367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: create supervdsm package
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: create supervdsm package
......................................................................
Patch Set 13: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/69079/13/configure.ac
File configure.ac:
Line 1: #
Line 2: # Copyright 2008-2016 Red Hat, Inc.
change to 2017
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
https://gerrit.ovirt.org/#/c/69079/13/lib/vdsm/gluster/api.py
File lib/vdsm/gluster/api.py:
Line 1: #
Line 2: # Copyright 2012-2016 Red Hat, Inc.
2017
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 27: from vdsm.common.define import doneCode
Line 28: from vdsm.gluster import exception as ge
Line 29: from vdsm.gluster import fstab
Line 30: from vdsm.storage import mount
Line 31: from vdsm.supervdsm import proxy as svdsm
svdsm is good. or you could just call the module sproxy instead of proxy
Line 32: from vdsm import constants
Line 33: from vdsm import commands
Line 34: from vdsm import utils
Line 35: from pwd import getpwnam
https://gerrit.ovirt.org/#/c/69079/13/lib/vdsm/host/caps.py
File lib/vdsm/host/caps.py:
Line 28:
Line 29: from vdsm.config import config
Line 30: from vdsm.host import rngsources
Line 31: from vdsm.storage import hba
Line 32: from vdsm.supervdsm import proxy
better to import that as supervdsm_proxy or something.. proxy is too general
Line 33: from vdsm import containersconnection
Line 34: from vdsm import cpuarch
Line 35: from vdsm import cpuinfo
Line 36: from vdsm import dsaversion
https://gerrit.ovirt.org/#/c/69079/13/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:
Line 1: #
Line 2: # Copyright 2014 Red Hat, Inc.
-2017
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
--
To view, visit https://gerrit.ovirt.org/69079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05c9c21912bb4bf27b68db5d0d4affb0f5ac7e81
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 3 months
Change in vdsm[master]: create supervdsm package
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: create supervdsm package
......................................................................
Patch Set 13: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/69079
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05c9c21912bb4bf27b68db5d0d4affb0f5ac7e81
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: spec net: During VDSM upgrade, reset vdsm-network service
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: spec net: During VDSM upgrade, reset vdsm-network service
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/73561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: spec net: During VDSM upgrade, reset vdsm-network service
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: spec net: During VDSM upgrade, reset vdsm-network service
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/73561
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib574a89d33fafccf9f4ceca13ff9dae17f51dcf8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: add dhclient to dependencies
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: add dhclient to dependencies
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73367
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If9c5479d84e41e6c085f973f152f7722370bcbf4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months
Change in vdsm[master]: net: Use netinfo iface users check version (instead of iface...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Use netinfo iface users check version (instead of ifaceUsed)
......................................................................
net: Use netinfo iface users check version (instead of ifaceUsed)
Checking if an iface is used by other devices has two implementetions:
- Check against existing kernel config: ifaceUsed()
- Check against a given netinfo instance content: NetInfo.ifaceUsers()
Both are based on the kernel config with some specific differences:
- The first is directly checking against the kernel and includes a check
against libvirt for the network existance.
- The second is checking against netinfo content, which was previously
collected from the kernel and from libvirt for the networks.
Note: Networks as entities are collected by netinfo from libvirt at the
moment. NetInfo acts as an abstraction layer, allowing future patches
to change the source of the data without affecting its users.
Future patches will change the network data source from libvirt to
running config.
Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/models.py
M lib/vdsm/network/netinfo/cache.py
5 files changed, 20 insertions(+), 11 deletions(-)
Approvals:
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved; Passed CI tests
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/72827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: net: Push NetInfo object down the ifcfg setup flow
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Push NetInfo object down the ifcfg setup flow
......................................................................
net: Push NetInfo object down the ifcfg setup flow
In this patch, the transaction NetInfo instance is pushed down through
the ifcfg configurator setup flow.
This patch is the first step to use NetInfo.ifaceUsers()
instead of ifaceUsed(), making NetInfo available where it is needed.
In the next patch ifaceUsed() is replaced by NetInfo.ifaceUsers()
Change-Id: Icddf479171b7a4d05ed803bd199831f59a7e9167
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M lib/vdsm/network/configurators/__init__.py
M lib/vdsm/network/configurators/ifcfg.py
M lib/vdsm/network/configurators/iproute2.py
M lib/vdsm/network/configurators/qos.py
M lib/vdsm/network/netswitch.py
M tests/network/config_network_test.py
6 files changed, 24 insertions(+), 20 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Petr Horáček: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/72826
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icddf479171b7a4d05ed803bd199831f59a7e9167
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 3 months
Change in vdsm[master]: net: Use netinfo iface users check version (instead of iface...
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net: Use netinfo iface users check version (instead of ifaceUsed)
......................................................................
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/72827
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6cb0c24c105ccf84f432f4e526206f6f9a48e09
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 3 months