Change in vdsm[master]: mailbox: Add tests for mailbox validation
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: mailbox: Add tests for mailbox validation
......................................................................
mailbox: Add tests for mailbox validation
When SPM mailbox is reading new mail, it validates the mailbox checksum.
Add tests before modifying this code.
Change-Id: I4ec15704cc913777b5bf9dd8bd983cdec6336673
Bug-Url: https://bugzilla.redhat.com/1426762
Signed-off-by: Nir Soffer <nsoffer(a)redhat.com>
---
M lib/vdsm/storage/mailbox.py
M tests/storage_mailbox_test.py
2 files changed, 32 insertions(+), 2 deletions(-)
Approvals:
Adam Litke: Looks good to me, approved
Nir Soffer: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/73077
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4ec15704cc913777b5bf9dd8bd983cdec6336673
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: net tests: Add grace/synchronization period for mode4 bonds.
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: Add grace/synchronization period for mode4 bonds.
......................................................................
Patch Set 22: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/73042
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70ad2e8fbf2b54971eba79f8de44e199e54ae4e3
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: osinfo: show variant name in osname for ngn hosts
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: osinfo: show variant name in osname for ngn hosts
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/73403/2//COMMIT_MSG
Commit Message:
Line 7: osinfo: show variant name in osname for ngn hosts
Line 8:
Line 9: Currently, vdsm provides OS name for NGN hosts incorrectly, i.e:
Line 10: it shows RHVH node as RHEL node, which may lead users to confusion
Line 11: when visualizating OS data in Engine GUI. This patch adds variant
what is the output before and after this patch, on RHVH and on RHEL?
Is it really related to the cited bug? Is migration broken without it?
Line 12: name as osname for ngn hosts.
Line 13:
Line 14: Change-Id: I2253e0ba9c3bec8e3c02a9197d3fc8b1fc11ade6
Line 15: Bug-Url: https://bugzilla.redhat.com/1425174
--
To view, visit https://gerrit.ovirt.org/73403
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2253e0ba9c3bec8e3c02a9197d3fc8b1fc11ade6
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
7 years, 2 months
Change in vdsm[master]: contrib: configurable VDSM_DIR in shell_helper
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: configurable VDSM_DIR in shell_helper
......................................................................
Patch Set 3: -Code-Review
--
To view, visit https://gerrit.ovirt.org/73129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8db64d3aaa2269ceeb046cc0b6448e0166e2cecb
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: v2v: move QCOW2 setting to vminfo
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: move QCOW2 setting to vminfo
......................................................................
v2v: move QCOW2 setting to vminfo
patch I846e75e6292c0b249e66b08ceec6b371e9b50f22 added ability for
setting QCOW2 version while importing by adding a new parameter version
to the api.
This change require the engine to have two signatures of
convertExternalVm and convertExternalVmFromOva verbs for backward
compatibility.
moving the setting to the vminfo structure will leave the api as is and
will not require handling of backward compatibility.
Change-Id: I7eb649b92e646d457d77c822ce1000fde09995c8
Bug-Url: https://bugzilla.redhat.com/1412451
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M lib/vdsm/api/vdsm-api.yml
M lib/vdsm/v2v.py
M tests/v2v_test.py
M vdsm/API.py
4 files changed, 35 insertions(+), 50 deletions(-)
Approvals:
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71665
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7eb649b92e646d457d77c822ce1000fde09995c8
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: schema: add new type ExternalVmParams and ExternalDiskParams
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: add new type ExternalVmParams and ExternalDiskParams
......................................................................
schema: add new type ExternalVmParams and ExternalDiskParams
currently v2v use ExternalVmInfo and ExternalDiskInfo for all the
getExternalVm* methods and for all the convertVm* methods.
convertVm* uses other values that the engine changes so adding a new
type ExternalVmParams and ExternalDiskParams for all the convertVm* methods.
Change-Id: Id310093339548f72a1ed8747df879217b5784cf3
Signed-off-by: Shahar Havivi <shaharh(a)redhat.com>
---
M lib/vdsm/api/vdsm-api.yml
1 file changed, 56 insertions(+), 2 deletions(-)
Approvals:
Piotr Kliczewski: Looks good to me, approved
Shahar Havivi: Verified
Jenkins CI: Passed CI tests
Francesco Romani: Looks good to me, approved
Tomas Golembiovsky: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/71879
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id310093339548f72a1ed8747df879217b5784cf3
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: contrib: configurable VDSM_DIR in shell_helper
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: contrib: configurable VDSM_DIR in shell_helper
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/73129
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8db64d3aaa2269ceeb046cc0b6448e0166e2cecb
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: network: remove Node reference
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: network: remove Node reference
......................................................................
network: remove Node reference
Change-Id: I1f973d949daa8b3d9a30d45761a6b77aaa579528
Signed-off-by: Petr Horáček <phoracek(a)redhat.com>
---
M lib/vdsm/network/netconfpersistence.py
1 file changed, 0 insertions(+), 3 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Dan Kenigsberg: Verified; Looks good to me, approved
Edward Haas: Looks good to me, but someone else must approve
--
To view, visit https://gerrit.ovirt.org/72511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1f973d949daa8b3d9a30d45761a6b77aaa579528
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months
Change in vdsm[master]: network: remove Node reference
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: network: remove Node reference
......................................................................
Patch Set 1: Code-Review+2 Verified+1
comment removal, no need in v+1.
--
To view, visit https://gerrit.ovirt.org/72511
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f973d949daa8b3d9a30d45761a6b77aaa579528
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
7 years, 2 months
Change in vdsm[master]: gluster: add missing gluster exception
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: gluster: add missing gluster exception
......................................................................
gluster: add missing gluster exception
GlusterHostStorageDeviceMkfsFailedException is missing in
gluster/exception.py and wrong arugments are passed in
gluster/storagedev.py. This patche adds the missing exception \
and corrects the arguments passed.
Change-Id: I86c396bc7f80ea3cf60056db6010ccc7b0c172f9
Signed-off-by: Ramesh Nachimuthu <rnachimu(a)redhat.com>
---
M lib/vdsm/gluster/exception.py
M lib/vdsm/gluster/storagedev.py
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Sahina Bose: Looks good to me, but someone else must approve
Ramesh N: Verified
--
To view, visit https://gerrit.ovirt.org/73171
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I86c396bc7f80ea3cf60056db6010ccc7b0c172f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
7 years, 2 months